LayoutTests/fast/css/overflow-rtl-border-after.html - Issue 18720003: Correct overflow propagation in BTT and RTL writing-modes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/overflow-rtl-border-after.html

Issue 18720003: Correct overflow propagation in BTT and RTL writing-modes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/overflow-btt-border-after-expected.txt ('k') | LayoutTests/fast/css/overflow-rtl-border-after-expected.txt » ('j') | Source/core/rendering/RenderBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Border-after in vertical-rl mode, non-visible overflow</title>

	5 <style>

	6 body { color:black; background:white; }

	7 #container {

	8 -webkit-writing-mode: vertical-rl;

	9 overflow:hidden;

	10 -webkit-logical-height:100px;

	11 -webkit-border-after:150px solid white;
	Julien - ping for review 2013/07/15 23:50:33 I would rather have the test use physical coordina I would rather have the test use physical coordinates (and non-proprietary extensions as we will need to deal with them at some point) mstensho (USE GERRIT) 2013/07/17 13:39:36 Done. Show quoted text On 2013/07/15 23:50:33, Julien Chaffraix wrote: > I would rather have the test use physical coordinates (and non-proprietary > extensions as we will need to deal with them at some point) Done.
	12 background:red;

	13 }

	14 #inner { -webkit-logical-height:200px; background:white; }

	15 </style>

	16 <script>

	17 if (window.testRunner)

	18 testRunner.dumpAsText();

	19 </script>

	20 </head>

	21 <body>

	22 <p>The word 'HEST' should be seen below, and there should be no red.</p>

	23 <div id="container">

	24 <div id="inner">HEST</div>

	25 </div>

	26 <script>

	27 if (window.testRunner) {

	28 var logicalHeight = container.scrollWidth;

	29 document.body.innerHTML = logicalHeight == 200 ? "PASS" : "FAIL - logica lHeight was " + logicalHeight;
	Julien - ping for review 2013/07/15 23:50:33 I think this should be a check-layout.js test. Thi I think this should be a check-layout.js test. This would remove the need for the custom JS code altogether: <div id="inner" data-expected-scroll-width="200">HEST</div> The bonus: it would also work outside of DumpRenderTree as this code wouldn't be run as-is. mstensho (USE GERRIT) 2013/07/17 13:39:36 Done. And thanks for the tip. Show quoted text On 2013/07/15 23:50:33, Julien Chaffraix wrote: > I think this should be a check-layout.js test. This would remove the need for > the custom JS code altogether: > > <div id="inner" data-expected-scroll-width="200">HEST</div> > > The bonus: it would also work outside of DumpRenderTree as this code wouldn't be > run as-is. Done. And thanks for the tip.
	30 }

	31 </script>

	32 </body>

	33 </html>

OLD	NEW