Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/GraphicsLayerUpdater.cpp
diff --git a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp
index 40c419947199076cd33c2a73106ab36d3df34799..882b60974288f3eae94be1fd35a6cce65520bd3b 100644
--- a/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp
+++ b/Source/core/rendering/compositing/GraphicsLayerUpdater.cpp
@@ -27,6 +27,7 @@
#include "config.h"
#include "core/rendering/compositing/GraphicsLayerUpdater.h"
+#include "core/html/HTMLMediaElement.h"
#include "core/rendering/RenderLayer.h"
#include "core/rendering/RenderLayerReflectionInfo.h"
#include "core/rendering/RenderPart.h"
@@ -123,6 +124,16 @@ void GraphicsLayerUpdater::rebuildTree(RenderLayer& layer, Vector<GraphicsLayer*
}
childLayersOfEnclosingLayer.append(currentCompositedLayerMapping->childForSuperlayers());
+ bool appendLayer = true;
+ if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {
+ Node* node = layer.renderer()->node();
+ if (isHTMLMediaElement(*node) && toHTMLMediaElement(node)->isFullscreen()) {
+ appendLayer = false;
+ }
+ }
+ if (appendLayer) {
esprehn 2014/03/05 00:22:41 This should be refactored into a function. if (sh
qinmin 2014/03/05 01:34:42 Done.
+ childLayersOfEnclosingLayer.append(currentCompositedLayerMapping->childForSuperlayers());
+ }
}
if (!depth) {

Powered by Google App Engine
This is Rietveld 408576698