LayoutTests/fullscreen/full-screen-test.js - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fullscreen/full-screen-test.js

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fullscreen/full-screen-iframe-allowed-video.html ('K') | « LayoutTests/fullscreen/full-screen-iframe-allowed-video-expected.txt ('k') | LayoutTests/fullscreen/resources/video.html » ('j') | LayoutTests/fullscreen/resources/video.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fullscreen/full-screen-test.js

diff --git a/LayoutTests/fullscreen/full-screen-test.js b/LayoutTests/fullscreen/full-screen-test.js

index 4f25a8d682a0c1ddf7adac996fe55989074cb767..dbba9684aef40e492cea5d58487d71aea99ad867 100644

--- a/LayoutTests/fullscreen/full-screen-test.js

+++ b/LayoutTests/fullscreen/full-screen-test.js

@@ -4,7 +4,10 @@ var printFullTestDetails = true; // This is optionaly switched of by test whose

logConsole();

if (window.testRunner) {

- testRunner.dumpAsText();

+ if (window.runPixelTests)

+ testRunner.dumpAsTextWithPixelResults();

+ else

+ testRunner.dumpAsText();

testRunner.waitUntilDone();

}