LayoutTests/fullscreen/resources/video.html - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/resources/video.html

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fullscreen/full-screen-iframe-allowed-video.html ('K') | « LayoutTests/fullscreen/full-screen-test.js ('k') | LayoutTests/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png » ('j') | Source/core/rendering/compositing/GraphicsLayerUpdater.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../media/media-file.js"></script>

	3 <script>

	4 function canplaythrough() {

	5 parent.postMessage("Video loaded", "*");

	6 }

	7

	8 function fullscreenChanged() {

	9 parent.postMessage("SUCCEED - entered full screen!", "*");

	10 }

	11

	12 onload = function() {

	13 var video = document.getElementById('video');

	14 var mediaFile = findMediaFile("video", "../../media/content/test");

	15 video.src = mediaFile;

	16 video.addEventListener('canplaythrough', canplaythrough);

	17 video.addEventListener('webkitfullscreenchange', fullscreenChanged);

	18 video.onclick = function() {

	19 video.webkitRequestFullscreen();

	20 };

	21 }

	22 </script>

	23 <video id="video" controls width="320" height="240"></video>

OLD	NEW