LayoutTests/fullscreen/full-screen-iframe-allowed-video.html - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-iframe-allowed-video.html

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fullscreen/full-screen-iframe-allowed-video-expected.txt » ('j') | Source/core/rendering/compositing/GraphicsLayerUpdater.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.internals)

	4 runPixelTests = internals.runtimeFlags.overlayFullscreenVideoEnabled;

	5 </script>

	6 <script src="full-screen-test.js"></script>

	7 <script>

	8 var initialized = false;

	9 window.onmessage = function(messageEvent) {

	10 if (!initialized) {

	11 // video has been loaded and messaged us.

	12 // Send click to center of iframe.

	13 iframe = document.getElementById("frame");

	14 x = iframe.offsetLeft + iframe.offsetWidth / 2;

	15 y = iframe.offsetTop + iframe.offsetHeight / 2;

	16 if (window.eventSender) {

	17 eventSender.mouseMoveTo(x, y);

	18 eventSender.mouseDown();

	19 eventSender.mouseUp();

	20 }

	21 initialized = true;

	22 }

	23 else {
	esprehn 2014/03/05 04:36:03 else goes on the same line as the brace else goes on the same line as the brace qinmin 2014/03/05 18:45:25 Done. Show quoted text On 2014/03/05 04:36:03, esprehn wrote: > else goes on the same line as the brace Done.
	24 consoleWrite(messageEvent.data);

	25 endTest();

	26 }

	27 }

	28 </script>

	29 Video inside an iframe is allowed to enter fullscreen</p>

	30 <iframe id="frame" src="resources/video.html" width="320" height="240" allowfull screen></iframe>

	31

OLD	NEW