Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 const FrameView::ScrollableAreaSet* scrollableAreas = m_renderView->frameVie w()->scrollableAreas(); 307 const FrameView::ScrollableAreaSet* scrollableAreas = m_renderView->frameVie w()->scrollableAreas();
308 if (!scrollableAreas) 308 if (!scrollableAreas)
309 return; 309 return;
310 310
311 for (FrameView::ScrollableAreaSet::iterator it = scrollableAreas->begin(); i t != scrollableAreas->end(); ++it) 311 for (FrameView::ScrollableAreaSet::iterator it = scrollableAreas->begin(); i t != scrollableAreas->end(); ++it)
312 (*it)->updateNeedsCompositedScrolling(); 312 (*it)->updateNeedsCompositedScrolling();
313 } 313 }
314 314
315 static RenderVideo* findFullscreenVideoRenderer(Document& document) 315 static RenderVideo* findFullscreenVideoRenderer(Document& document)
316 { 316 {
317 Element* fullscreenElement = FullscreenElementStack::currentFullScreenElemen tFrom(document); 317 Element* fullscreenElement = FullscreenElementStack::fullscreenElementFrom(d ocument);
318 while (fullscreenElement && fullscreenElement->isFrameOwnerElement()) { 318 while (fullscreenElement && fullscreenElement->isFrameOwnerElement()) {
319 Document* contentDocument = toHTMLFrameOwnerElement(fullscreenElement)-> contentDocument(); 319 Document* contentDocument = toHTMLFrameOwnerElement(fullscreenElement)-> contentDocument();
320 if (!contentDocument) 320 if (!contentDocument)
321 return 0; 321 return 0;
322 fullscreenElement = FullscreenElementStack::currentFullScreenElementFrom (*contentDocument); 322 fullscreenElement = FullscreenElementStack::fullscreenElementFrom(*conte ntDocument);
323 } 323 }
324 if (!fullscreenElement || !fullscreenElement->hasTagName(videoTag)) 324 if (!fullscreenElement || !fullscreenElement->hasTagName(videoTag))
325 return 0; 325 return 0;
326 RenderObject* renderer = fullscreenElement->renderer(); 326 RenderObject* renderer = fullscreenElement->renderer();
327 if (!renderer) 327 if (!renderer)
328 return 0; 328 return 0;
329 return toRenderVideo(renderer); 329 return toRenderVideo(renderer);
330 } 330 }
331 331
332 void RenderLayerCompositor::finishCompositingUpdateForFrameTree(LocalFrame* fram e) 332 void RenderLayerCompositor::finishCompositingUpdateForFrameTree(LocalFrame* fram e)
(...skipping 1898 matching lines...) Expand 10 before | Expand all | Expand 10 after
2231 } else if (graphicsLayer == m_scrollLayer.get()) { 2231 } else if (graphicsLayer == m_scrollLayer.get()) {
2232 name = "LocalFrame Scrolling Layer"; 2232 name = "LocalFrame Scrolling Layer";
2233 } else { 2233 } else {
2234 ASSERT_NOT_REACHED(); 2234 ASSERT_NOT_REACHED();
2235 } 2235 }
2236 2236
2237 return name; 2237 return name;
2238 } 2238 }
2239 2239
2240 } // namespace WebCore 2240 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698