LayoutTests/fullscreen/full-screen-iframe-allowed-video.html - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-iframe-allowed-video.html

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fullscreen/full-screen-iframe-allowed-video-expected.txt » ('j') | LayoutTests/fullscreen/resources/video.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	esprehn 2014/03/05 00:22:41 Leave out <html>, <head> and <body> then this test Leave out <html>, <head> and <body> then this test won't be indented so far. qinmin 2014/03/05 01:34:42 Done. Show quoted text On 2014/03/05 00:22:41, esprehn wrote: > Leave out <html>, <head> and <body> then this test won't be indented so far. Done.
	4 <script>

	5 if (window.internals)

	6 runPixelTests = internals.runtimeFlags.overlayFullscreenVideoEna bled;

	7 </script>

	8 <script src="full-screen-test.js"></script>

	9 <script>

	10 window.onmessage = function () { // video has been loaded and messag ed us.
	esprehn 2014/03/05 00:22:41 no space after function no space after function qinmin 2014/03/05 01:34:42 Done. Show quoted text On 2014/03/05 00:22:41, esprehn wrote: > no space after function Done.
	11 // Send click to center of iframe.

	12 iframe = document.getElementById("frame");

	13 x = iframe.offsetLeft + iframe.offsetWidth / 2;

	14 y = iframe.offsetTop + iframe.offsetHeight / 2;

	15 if (window.eventSender) {

	16 eventSender.mouseMoveTo(x, y);

	17 eventSender.mouseDown();

	18 eventSender.mouseUp();

	19 }

	20 window.onmessage = function (messageEvent) {
	esprehn 2014/03/05 00:22:41 This is pretty weird, you overwrite yourself here. This is pretty weird, you overwrite yourself here. :/ qinmin 2014/03/05 01:34:42 ok, use a variable to remember whether the video h ok, use a variable to remember whether the video has been initialized or not On 2014/03/05 00:22:41, esprehn wrote: Show quoted text > This is pretty weird, you overwrite yourself here. :/
	21 consoleWrite(messageEvent.data);

	22 endTest();

	23 }

	24 }

	25 </script>

	26 </head>

	27 <body>

	28 Video inside an iframe is allowed to enter fullscreen</p>

	29 <iframe id="frame" src="resources/video.html" width="320" height="240" a llowfullscreen></iframe>

	30 </body>

	31 </html>

OLD	NEW