tools/safari_factory_reset.py - Issue 1871883002: Make Safari tests more robust. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(15)

My Issues | Starred Open | Closed | All

Unified Diff: tools/safari_factory_reset.py

Issue 1871883002: Make Safari tests more robust. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Status updates and fix a typo. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « tests/html/html.status ('k') | tools/testing/dart/browser_controller.dart » ('j') | tools/testing/dart/browser_controller.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/safari_factory_reset.py

diff --git a/tools/test.py b/tools/safari_factory_reset.py

similarity index 90%

copy from tools/test.py

copy to tools/safari_factory_reset.py

index 9a32fa597bf68faeae573e8cf4e4210aeff5a12f..eb44b6f01bb470c8d17d4f031780cf10c23589e2 100755

--- a/tools/test.py

+++ b/tools/safari_factory_reset.py

@@ -14,7 +14,7 @@ import utils

def Main():

args = sys.argv[1:]

tools_dir = os.path.dirname(os.path.realpath(__file__))

- dart_script_name = 'test.dart'

+ dart_script_name = os.path.join('testing', 'dart', 'reset_safari.dart');

dart_test_script = string.join([tools_dir, dart_script_name], os.sep)

Bill Hesse 2016/04/25 08:20:18 I would join tools_dir in the os.path.join in the

ahe 2016/05/24 08:44:42 Done.

command = [utils.CheckedInSdkExecutable(),

'--checked', dart_test_script] + args

« no previous file with comments | « tests/html/html.status ('k') | tools/testing/dart/browser_controller.dart » ('j') | tools/testing/dart/browser_controller.dart » ('J')

Powered by Google App Engine

This is Rietveld 408576698