tools/testing/dart/test_configurations.dart - Issue 1871883002: Make Safari tests more robust.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_configurations.dart

Issue 1871883002: Make Safari tests more robust. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_configurations.dart

diff --git a/tools/testing/dart/test_configurations.dart b/tools/testing/dart/test_configurations.dart

index f8cd209ab16234d45a9c4520304dc603e8ffa91c..030ec4fc0d881e4f00c81cf614c225140cfefe59 100644

--- a/tools/testing/dart/test_configurations.dart

+++ b/tools/testing/dart/test_configurations.dart

@@ -69,7 +69,7 @@ Future testConfigurations(List<Map> configurations) async {

var recordingPath = firstConf['record_to_file'];

var recordingOutputPath = firstConf['replay_from_file'];

- Browser.deleteCache = firstConf['clear_browser_cache'];

+ Browser.resetBrowserConfiguration = firstConf['reset_browser_configuration'];

if (recordingPath != null && recordingOutputPath != null) {

print("Fatal: Can't have the '--record_to_file' and '--replay_from_file'"

« no previous file with comments | « tools/testing/dart/reset_safari.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »