test_safari.sh - Issue 1871883002: Make Safari tests more robust.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test_safari.sh

Issue 1871883002: Make Safari tests more robust. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/sh

	2

	3 ./nuke_safari.sh

	4

	5 if lsof -t /Applications/Safari.app/Contents/MacOS/Safari ; then
	ahe 2016/04/08 12:56:53 Not sure how to integrate this test and the next i Not sure how to integrate this test and the next into browser_controller.dart. Perhaps these checks should be moved to nuke_safari.sh.
	6 echo Safari still running >&2

	7 exit 1

	8 fi

	9

	10 if pkill -HUP com.apple.Safari ; then

	11 echo Safari helpers still running >&2

	12 exit 1

	13 fi

	14

	15 set -x

	16

	17 exec ./tools/test.py '--mode=release' '--arch=ia32' '--compiler=dart2js' --dart2 js-batch '--runtime=safari' --clear_browser_cache --report --time --failure-summ ary -v -t60

OLD	NEW