Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1871753002: Blink web RunAllTests.cpp: add mojo initialization (Closed)

Created:
4 years, 8 months ago by mcasas
Modified:
4 years, 8 months ago
Reviewers:
haraken, esprehn
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Source/web RunAllTests.cpp: add mojo initialization Blink modules/ unittests will need mojo initialized (actually, imminently in http://crrev.com/1794553002) modules/ unittests are piggibacking on web/ tests, so this CL adds mojo initialization there. BUG=601548 TEST= all tests etc passing. Committed: https://crrev.com/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6 Cr-Commit-Position: refs/heads/master@{#385936}

Patch Set 1 #

Patch Set 2 : BUILD.gn webkit_unit_tests #

Patch Set 3 : s'moar BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/web/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RunAllTests.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mcasas
haraken@/esprehn@ PTAL -- one should be enough :)
4 years, 8 months ago (2016-04-07 23:52:38 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-08 00:03:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871753002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871753002/30001
4 years, 8 months ago (2016-04-08 00:20:53 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 8 months ago (2016-04-08 00:26:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 00:28:43 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a233807cc4036b90d2cc2ca4a9e45f91d160f2b6
Cr-Commit-Position: refs/heads/master@{#385936}

Powered by Google App Engine
This is Rietveld 408576698