Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1871743003: ui: Add out-of-line copy ctors for complex classes. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
Nico, sky, dcheng
CC:
cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, kalyank, nona+watch_chromium.org, oshima+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, James Su, tdresser+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=sky@chromium.org, dcheng@chromium.org, thakis@chromium.org Committed: https://crrev.com/8108fdfbb79cd724babed932cd570c234a033ee8 Cr-Commit-Position: refs/heads/master@{#386155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M ui/base/ime/chromeos/component_extension_ime_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/input_method_descriptor.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/chromeos/input_method_descriptor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/input_method_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/chromeos/input_method_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_evdev_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_evdev_types.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/geometry/cubic_bezier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/geometry/cubic_bezier.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/render_text_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_overlay.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_overlay.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/fake_plane_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/fake_plane_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/overlay_plane.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/overlay_plane.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/public/overlay_candidates_ozone.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/public/overlay_candidates_ozone.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/public/surface_ozone_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/public/surface_ozone_egl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-04-07 22:25:37 UTC) #1
dcheng
rs lgtm
4 years, 8 months ago (2016-04-07 22:26:43 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-07 23:28:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871743003/1
4 years, 8 months ago (2016-04-08 00:55:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/171480)
4 years, 8 months ago (2016-04-08 01:34:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871743003/1
4 years, 8 months ago (2016-04-08 18:04:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 18:56:00 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:57:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8108fdfbb79cd724babed932cd570c234a033ee8
Cr-Commit-Position: refs/heads/master@{#386155}

Powered by Google App Engine
This is Rietveld 408576698