Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: components/metrics/metrics_service.cc

Issue 1871733002: Add histograms for observing UMA throttling effect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 315229b11d1f0e73a6fcf399d4427d64aa47b748..24aa4f4a7ec4ed77b4d6ddfdc398bf0c270062be 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -882,13 +882,17 @@ void MetricsService::SendNextLog() {
// Proceed to stage the log for upload if log size satisfies cellular log
// upload constrains.
+ bool upload_canceled = false;
if (client_->IsUMACellularUploadLogicEnabled() &&
!data_use_tracker_->ShouldUploadLogOnCellular(
log_manager_.staged_log_hash().size())) {
scheduler_->UploadCancelled();
+ upload_canceled = true;
} else {
SendStagedLog();
}
+ UMA_HISTOGRAM_BOOLEAN("UMA.LogUpload.Canceled.CellularConstraint",
Alexei Svitkine (slow) 2016/04/11 15:09:08 Let's not log this unless IsUMACellularUploadLogic
gayane -on leave until 09-2017 2016/04/11 15:40:46 Done.
+ upload_canceled);
}
bool MetricsService::ProvidersHaveInitialStabilityMetrics() {
« no previous file with comments | « no previous file | components/metrics/net/net_metrics_log_uploader.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698