components/metrics/metrics_service.cc - Issue 1871733002: Add histograms for observing UMA throttling effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.cc

Issue 1871733002: Add histograms for observing UMA throttling effect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/metrics/metrics_reporting_scheduler.cc ('K') | « components/metrics/metrics_reporting_scheduler.cc ('k') | components/metrics/net/net_metrics_log_uploader.cc » ('j') | components/metrics/persisted_logs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index 315229b11d1f0e73a6fcf399d4427d64aa47b748..77f79cc5a5d1acaee6b11c91c30f0b87816e73e2 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -886,8 +886,10 @@ void MetricsService::SendNextLog() {

!data_use_tracker_->ShouldUploadLogOnCellular(

log_manager_.staged_log_hash().size())) {

scheduler_->UploadCancelled();

+ UMA_HISTOGRAM_BOOLEAN("UMA.LogUpload.Canceled.CellularConstraint", true);

Alexei Svitkine (slow) 2016/04/08 20:07:12 Can we log this only if Cellular upload logic is e

gayane -on leave until 09-2017 2016/04/08 20:40:14 I am not sure I follow. It is the the IF with clie

} else {

SendStagedLog();

+ UMA_HISTOGRAM_BOOLEAN("UMA.LogUpload.Canceled.CellularConstraint", false);

Alexei Svitkine (slow) 2016/04/08 20:07:12 UMA macros expand to a bunch of code. Please refac

gayane -on leave until 09-2017 2016/04/08 20:40:14 Done.

}