Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: components/metrics/net/net_metrics_log_uploader.cc

Issue 1871733002: Add histograms for observing UMA throttling effect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/net/net_metrics_log_uploader.cc
diff --git a/components/metrics/net/net_metrics_log_uploader.cc b/components/metrics/net/net_metrics_log_uploader.cc
index 0ded667b78783bc71a0deb3ec851db8a53faf4cc..7f76da2c082fea619d6eee4ad333abd614996bf2 100644
--- a/components/metrics/net/net_metrics_log_uploader.cc
+++ b/components/metrics/net/net_metrics_log_uploader.cc
@@ -7,23 +7,9 @@
#include "base/metrics/histogram_macros.h"
#include "components/data_use_measurement/core/data_use_user_data.h"
#include "net/base/load_flags.h"
-#include "net/base/network_change_notifier.h"
#include "net/url_request/url_fetcher.h"
#include "url/gurl.h"
-namespace {
-
-// Records the network connection type if upload was successful.
-void RecordConnectionType(int response_code) {
- if (response_code == 200) {
- UMA_HISTOGRAM_ENUMERATION("UMA.LogUpload.ConnetionType",
- net::NetworkChangeNotifier::GetConnectionType(),
- net::NetworkChangeNotifier::CONNECTION_LAST);
- }
-}
-
-} // namespace
-
namespace metrics {
NetMetricsLogUploader::NetMetricsLogUploader(
@@ -70,7 +56,6 @@ void NetMetricsLogUploader::OnURLFetchComplete(const net::URLFetcher* source) {
if (response_code == net::URLFetcher::RESPONSE_CODE_INVALID)
response_code = -1;
current_fetch_.reset();
- RecordConnectionType(response_code);
on_upload_complete_.Run(response_code);
}

Powered by Google App Engine
This is Rietveld 408576698