chrome/browser/extensions/api/device_permissions_manager_unittest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/device_permissions_manager_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc ('k') | chrome/browser/extensions/api/dial/dial_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/device_permissions_manager_unittest.cc

diff --git a/chrome/browser/extensions/api/device_permissions_manager_unittest.cc b/chrome/browser/extensions/api/device_permissions_manager_unittest.cc

index 92e10f687f56f3445146afaf2711337b6c5a96d6..eacf06e698a0ac2c14edefc69b972081f4459507 100644

--- a/chrome/browser/extensions/api/device_permissions_manager_unittest.cc

+++ b/chrome/browser/extensions/api/device_permissions_manager_unittest.cc

@@ -82,7 +82,7 @@ class DevicePermissionsManagerTest : public testing::Test {

void TearDown() override { env_.reset(nullptr); }

- scoped_ptr<extensions::TestExtensionEnvironment> env_;

+ std::unique_ptr<extensions::TestExtensionEnvironment> env_;

const extensions::Extension* extension_;

device::MockDeviceClient device_client_;

scoped_refptr<MockUsbDevice> device0_;

@@ -282,7 +282,7 @@ TEST_F(DevicePermissionsManagerTest, UpdateLastUsed) {

}

TEST_F(DevicePermissionsManagerTest, LoadPrefs) {

- scoped_ptr<base::Value> prefs_value = base::test::ParseJson(

+ std::unique_ptr<base::Value> prefs_value = base::test::ParseJson(

"["

" {"

" \"manufacturer_string\": \"Test Manufacturer\","