Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4280)

Unified Diff: chrome/browser/extensions/extension_view_host_factory_browsertest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_view_host.h ('k') | chrome/browser/extensions/extension_web_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_view_host_factory_browsertest.cc
diff --git a/chrome/browser/extensions/extension_view_host_factory_browsertest.cc b/chrome/browser/extensions/extension_view_host_factory_browsertest.cc
index 83d468a3b93ef67194bb22192351a8a92fc9ffdb..b72cb7a38fe1cf102addbcb119444e156a2e3798 100644
--- a/chrome/browser/extensions/extension_view_host_factory_browsertest.cc
+++ b/chrome/browser/extensions/extension_view_host_factory_browsertest.cc
@@ -27,7 +27,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionViewHostFactoryTest, CreateExtensionHosts) {
content::BrowserContext* browser_context = browser()->profile();
{
// Popup hosts are created with the correct type and profile.
- scoped_ptr<ExtensionViewHost> host(
+ std::unique_ptr<ExtensionViewHost> host(
ExtensionViewHostFactory::CreatePopupHost(extension->url(), browser()));
EXPECT_EQ(extension.get(), host->extension());
EXPECT_EQ(browser_context, host->browser_context());
@@ -37,7 +37,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionViewHostFactoryTest, CreateExtensionHosts) {
{
// Dialog hosts are created with the correct type and profile.
- scoped_ptr<ExtensionViewHost> host(
+ std::unique_ptr<ExtensionViewHost> host(
ExtensionViewHostFactory::CreateDialogHost(extension->url(),
browser()->profile()));
EXPECT_EQ(extension.get(), host->extension());
@@ -65,9 +65,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionViewHostFactoryTest,
// The ExtensionHost for a regular extension in an incognito window is
// associated with the original window's profile.
- scoped_ptr<ExtensionHost> regular_host(
- ExtensionViewHostFactory::CreatePopupHost(
- regular_extension->url(), incognito_browser));
+ std::unique_ptr<ExtensionHost> regular_host(
+ ExtensionViewHostFactory::CreatePopupHost(regular_extension->url(),
+ incognito_browser));
content::BrowserContext* browser_context = browser()->profile();
EXPECT_EQ(browser_context, regular_host->browser_context());
@@ -80,9 +80,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionViewHostFactoryTest,
// The ExtensionHost for a split-mode extension is associated with the
// incognito profile.
- scoped_ptr<ExtensionHost> split_mode_host(
- ExtensionViewHostFactory::CreatePopupHost(
- split_mode_extension->url(), incognito_browser));
+ std::unique_ptr<ExtensionHost> split_mode_host(
+ ExtensionViewHostFactory::CreatePopupHost(split_mode_extension->url(),
+ incognito_browser));
content::BrowserContext* incognito_context = incognito_browser->profile();
EXPECT_EQ(incognito_context, split_mode_host->browser_context());
}
« no previous file with comments | « chrome/browser/extensions/extension_view_host.h ('k') | chrome/browser/extensions/extension_web_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698