chrome/browser/extensions/api/feedback_private/feedback_service.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_service.h ('k') | chrome/browser/extensions/api/file_handlers/directory_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_service.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.cc b/chrome/browser/extensions/api/feedback_private/feedback_service.cc

index 13a7cbda759c1e483ff46a69fd6b116d5f9cef5d..18c46b8f3ea1bc12b9c0c32d8dae7fb9697dce21 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_service.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.cc

@@ -82,7 +82,7 @@ void FeedbackService::GetSystemInformation(

void FeedbackService::AttachedFileCallback(

scoped_refptr<feedback::FeedbackData> feedback_data,

const SendFeedbackCallback& callback,

- scoped_ptr<std::string> data,

+ std::unique_ptr<std::string> data,

int64_t /* total_blob_length */) {

feedback_data->set_attached_file_uuid(std::string());

if (data)

@@ -94,7 +94,7 @@ void FeedbackService::AttachedFileCallback(

void FeedbackService::ScreenshotCallback(

scoped_refptr<feedback::FeedbackData> feedback_data,

const SendFeedbackCallback& callback,

- scoped_ptr<std::string> data,

+ std::unique_ptr<std::string> data,

int64_t /* total_blob_length */) {

feedback_data->set_screenshot_uuid(std::string());

if (data)

@@ -105,7 +105,7 @@ void FeedbackService::ScreenshotCallback(

void FeedbackService::OnSystemLogsFetchComplete(

const GetSystemInformationCallback& callback,

- scoped_ptr<system_logs::SystemLogsResponse> sys_info_map) {

+ std::unique_ptr<system_logs::SystemLogsResponse> sys_info_map) {

SystemInformationList sys_info_list;

if (sys_info_map.get()) {

for (const auto& itr : *sys_info_map)