chrome/browser/extensions/api/gcd_private/gcd_private_api.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcd_private/gcd_private_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/extensions/api/gcd_private/gcd_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/gcd_private/gcd_private_api.h

diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_api.h b/chrome/browser/extensions/api/gcd_private/gcd_private_api.h

index 746e38739b808ce2def37a3891ee562938bf517b..8898b391cb8a78bd9e4cd7fa722ff81ceaa30cba 100644

--- a/chrome/browser/extensions/api/gcd_private/gcd_private_api.h

+++ b/chrome/browser/extensions/api/gcd_private/gcd_private_api.h

@@ -5,7 +5,8 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_GCD_PRIVATE_GCD_PRIVATE_API_H_

#define CHROME_BROWSER_EXTENSIONS_API_GCD_PRIVATE_GCD_PRIVATE_API_H_

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "chrome/browser/extensions/chrome_extension_function.h"

#include "chrome/common/extensions/api/gcd_private.h"

#include "extensions/browser/browser_context_keyed_api_factory.h"

@@ -29,7 +30,7 @@ class GcdPrivateAPI : public BrowserContextKeyedAPI {

// BrowserContextKeyedAPI implementation.

static const char* service_name() { return "GcdPrivateAPI"; }

- scoped_ptr<GcdPrivateAPIImpl> impl_;

+ std::unique_ptr<GcdPrivateAPIImpl> impl_;

};

class GcdPrivateGetDeviceInfoFunction : public ChromeAsyncExtensionFunction {