chrome/browser/extensions/api/braille_display_private/braille_controller.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmarks_api.cc ('k') | chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller.h

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller.h b/chrome/browser/extensions/api/braille_display_private/braille_controller.h

index 88c9b418850d7b8c55374b48b1a66db9583defda..73ec3e6b5fa496e72594e92d18b52fd9979760f7 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller.h

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller.h

@@ -5,11 +5,11 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_BRAILLE_DISPLAY_PRIVATE_BRAILLE_CONTROLLER_H_

#define CHROME_BROWSER_EXTENSIONS_API_BRAILLE_DISPLAY_PRIVATE_BRAILLE_CONTROLLER_H_

+#include <memory>

#include <vector>

#include "base/callback_forward.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/values.h"

#include "chrome/common/extensions/api/braille_display_private.h"

@@ -23,7 +23,7 @@ class BrailleController {

public:

static BrailleController* GetInstance();

- virtual scoped_ptr<DisplayState> GetDisplayState() = 0;

+ virtual std::unique_ptr<DisplayState> GetDisplayState() = 0;

virtual void WriteDots(const std::vector<char>& cells) = 0;

virtual void AddObserver(BrailleObserver* observer) = 0;

virtual void RemoveObserver(BrailleObserver* observer) = 0;