chrome/browser/extensions/api/image_writer_private/operation.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc ('k') | chrome/browser/extensions/api/image_writer_private/operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation.h

diff --git a/chrome/browser/extensions/api/image_writer_private/operation.h b/chrome/browser/extensions/api/image_writer_private/operation.h

index bf629529c3a2e4d374e17bb45967fd2db3da9108..c524d255a69257f69d80beb8ce3294f3fd12575d 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation.h

+++ b/chrome/browser/extensions/api/image_writer_private/operation.h

@@ -217,7 +217,7 @@ class Operation : public base::RefCountedThreadSafe<Operation> {

// Zip reader for unzip operations. The reason for using a pointer is that we

// don't want to include zip_reader.h here which can mangle definitions in

// jni.h when included in the same file. See crbug.com/554199.

- scoped_ptr<zip::ZipReader> zip_reader_;

+ std::unique_ptr<zip::ZipReader> zip_reader_;

// CleanUp operations that must be run. All these functions are run on the

// FILE thread.