Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/extensions/webstore_installer_browsertest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer_browsertest.cc
diff --git a/chrome/browser/extensions/webstore_installer_browsertest.cc b/chrome/browser/extensions/webstore_installer_browsertest.cc
index 92a080f85ef93f903837df867761c4f4ff2178d7..891dadf6fe8ac5bc734676a83ceac51c081b7cbc 100644
--- a/chrome/browser/extensions/webstore_installer_browsertest.cc
+++ b/chrome/browser/extensions/webstore_installer_browsertest.cc
@@ -39,7 +39,7 @@ class TestWebstoreInstaller : public WebstoreInstaller {
Delegate* delegate,
content::WebContents* web_contents,
const std::string& id,
- scoped_ptr<Approval> approval,
+ std::unique_ptr<Approval> approval,
InstallSource source)
: WebstoreInstaller(profile,
delegate,
@@ -117,7 +117,7 @@ void WebstoreInstallerBrowserTest::OnExtensionInstallFailure(
}
IN_PROC_BROWSER_TEST_F(WebstoreInstallerBrowserTest, WebstoreInstall) {
- scoped_ptr<base::DictionaryValue> manifest(
+ std::unique_ptr<base::DictionaryValue> manifest(
DictionaryBuilder()
.Set("name", kExtensionName)
.Set("description", "Foo")
@@ -131,7 +131,7 @@ IN_PROC_BROWSER_TEST_F(WebstoreInstallerBrowserTest, WebstoreInstall) {
ASSERT_TRUE(active_web_contents);
// Create an approval.
- scoped_ptr<WebstoreInstaller::Approval> approval =
+ std::unique_ptr<WebstoreInstaller::Approval> approval =
WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
browser()->profile(), kTestExtensionId, std::move(manifest), false);
@@ -150,7 +150,7 @@ IN_PROC_BROWSER_TEST_F(WebstoreInstallerBrowserTest, WebstoreInstall) {
}
IN_PROC_BROWSER_TEST_F(WebstoreInstallerBrowserTest, SimultaneousInstall) {
- scoped_ptr<base::DictionaryValue> manifest(
+ std::unique_ptr<base::DictionaryValue> manifest(
DictionaryBuilder()
.Set("name", kExtensionName)
.Set("description", "Foo")
@@ -164,12 +164,10 @@ IN_PROC_BROWSER_TEST_F(WebstoreInstallerBrowserTest, SimultaneousInstall) {
ASSERT_TRUE(active_web_contents);
// Create an approval.
- scoped_ptr<WebstoreInstaller::Approval> approval =
+ std::unique_ptr<WebstoreInstaller::Approval> approval =
WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
- browser()->profile(),
- kTestExtensionId,
- scoped_ptr<base::DictionaryValue>(manifest->DeepCopy()),
- false);
+ browser()->profile(), kTestExtensionId,
+ std::unique_ptr<base::DictionaryValue>(manifest->DeepCopy()), false);
// Create and run a WebstoreInstaller.
base::RunLoop run_loop;
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/extensions/webstore_installer_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698