chrome/browser/extensions/bookmark_app_helper.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc ('K') | « chrome/browser/extensions/bookmark_app_helper.h ('k') | chrome/browser/extensions/browser_action_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/bookmark_app_helper.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc

index ddb1d78843fb9b788b881bcf75a66b3e56fc5be5..737603531cc544d5c74ee1eb92472ef05b80aaea 100644

--- a/chrome/browser/extensions/bookmark_app_helper.cc

+++ b/chrome/browser/extensions/bookmark_app_helper.cc

@@ -325,8 +325,8 @@ class BookmarkAppInstaller : public base::RefCounted<BookmarkAppInstaller>,

ExtensionService* service_;

WebApplicationInfo web_app_info_;

- scoped_ptr<content::WebContents> web_contents_;

- scoped_ptr<FaviconDownloader> favicon_downloader_;

+ std::unique_ptr<content::WebContents> web_contents_;

+ std::unique_ptr<FaviconDownloader> favicon_downloader_;

std::vector<GURL> urls_to_download_;

std::vector<BookmarkAppHelper::BitmapAndSource> downloaded_bitmaps_;

};