chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc ('K') | « chrome/browser/extensions/api/declarative/declarative_apitest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

index 41ee988139dc07eaf9e94fbb447e9b3af255edaa..b0c4b93fd74706e6331dc048fcda57c27354ae4a 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc

@@ -102,11 +102,12 @@ TEST_F(RulesRegistryServiceTest, TestConstructionAndMultiThreading) {

message_loop_.RunUntilIdle();

// Test extension uninstalling.

- scoped_ptr<base::DictionaryValue> manifest = DictionaryBuilder()

- .Set("name", "Extension")

- .Set("version", "1.0")

- .Set("manifest_version", 2)

- .Build();

+ std::unique_ptr<base::DictionaryValue> manifest =

+ DictionaryBuilder()

+ .Set("name", "Extension")

+ .Set("version", "1.0")

+ .Set("manifest_version", 2)

+ .Build();

scoped_refptr<Extension> extension = ExtensionBuilder()

.SetManifest(std::move(manifest))

.SetID(kExtensionId)