chrome/browser/extensions/extension_util.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_util.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc ('K') | « chrome/browser/extensions/extension_user_script_loader_unittest.cc ('k') | chrome/browser/extensions/extension_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_util.h

diff --git a/chrome/browser/extensions/extension_util.h b/chrome/browser/extensions/extension_util.h

index b0d037974641d73b3a952006ec7fba3567903b9e..7fa21e4bbe8f8ba2d766a707e1eeaa7d44109a8e 100644

--- a/chrome/browser/extensions/extension_util.h

+++ b/chrome/browser/extensions/extension_util.h

@@ -5,9 +5,9 @@

#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UTIL_H_

#define CHROME_BROWSER_EXTENSIONS_EXTENSION_UTIL_H_

+#include <memory>

#include <string>

-#include "base/memory/scoped_ptr.h"

#include "url/gurl.h"

namespace base {

@@ -112,7 +112,8 @@ GURL GetSiteForExtensionId(const std::string& extension_id,

// Sets the name, id, and icon resource path of the given extension into the

// returned dictionary.

-scoped_ptr<base::DictionaryValue> GetExtensionInfo(const Extension* extension);

+std::unique_ptr<base::DictionaryValue> GetExtensionInfo(

+ const Extension* extension);

// Returns the default extension/app icon (for extensions or apps that don't

// have one).