Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/extensions/extension_action_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_action.h"
6
7 #include "base/memory/ptr_util.h"
5 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
6 #include "chrome/browser/extensions/extension_action.h"
7 #include "chrome/common/extensions/api/extension_action/action_info.h" 9 #include "chrome/common/extensions/api/extension_action/action_info.h"
8 #include "extensions/common/test_util.h" 10 #include "extensions/common/test_util.h"
9 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
10 #include "url/gurl.h" 12 #include "url/gurl.h"
11 13
12 namespace extensions { 14 namespace extensions {
13 15
14 namespace { 16 namespace {
15 17
16 scoped_ptr<ExtensionAction> CreateAction(ActionInfo::Type type, 18 std::unique_ptr<ExtensionAction> CreateAction(ActionInfo::Type type,
17 const ActionInfo& action_info) { 19 const ActionInfo& action_info) {
18 scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension(); 20 scoped_refptr<const Extension> extension = test_util::CreateEmptyExtension();
19 return make_scoped_ptr(new ExtensionAction(*extension, type, action_info)); 21 return base::WrapUnique(new ExtensionAction(*extension, type, action_info));
20 } 22 }
21 23
22 } // namespace 24 } // namespace
23 25
24 TEST(ExtensionActionTest, Title) { 26 TEST(ExtensionActionTest, Title) {
25 ActionInfo action_info; 27 ActionInfo action_info;
26 action_info.default_title = "Initial Title"; 28 action_info.default_title = "Initial Title";
27 scoped_ptr<ExtensionAction> action = 29 std::unique_ptr<ExtensionAction> action =
28 CreateAction(ActionInfo::TYPE_PAGE, action_info); 30 CreateAction(ActionInfo::TYPE_PAGE, action_info);
29 31
30 ASSERT_EQ("Initial Title", action->GetTitle(1)); 32 ASSERT_EQ("Initial Title", action->GetTitle(1));
31 action->SetTitle(ExtensionAction::kDefaultTabId, "foo"); 33 action->SetTitle(ExtensionAction::kDefaultTabId, "foo");
32 ASSERT_EQ("foo", action->GetTitle(1)); 34 ASSERT_EQ("foo", action->GetTitle(1));
33 ASSERT_EQ("foo", action->GetTitle(100)); 35 ASSERT_EQ("foo", action->GetTitle(100));
34 action->SetTitle(100, "bar"); 36 action->SetTitle(100, "bar");
35 ASSERT_EQ("foo", action->GetTitle(1)); 37 ASSERT_EQ("foo", action->GetTitle(1));
36 ASSERT_EQ("bar", action->GetTitle(100)); 38 ASSERT_EQ("bar", action->GetTitle(100));
37 action->SetTitle(ExtensionAction::kDefaultTabId, "baz"); 39 action->SetTitle(ExtensionAction::kDefaultTabId, "baz");
38 ASSERT_EQ("baz", action->GetTitle(1)); 40 ASSERT_EQ("baz", action->GetTitle(1));
39 action->ClearAllValuesForTab(100); 41 action->ClearAllValuesForTab(100);
40 ASSERT_EQ("baz", action->GetTitle(100)); 42 ASSERT_EQ("baz", action->GetTitle(100));
41 } 43 }
42 44
43 TEST(ExtensionActionTest, Visibility) { 45 TEST(ExtensionActionTest, Visibility) {
44 scoped_ptr<ExtensionAction> action = 46 std::unique_ptr<ExtensionAction> action =
45 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo()); 47 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo());
46 48
47 ASSERT_FALSE(action->GetIsVisible(1)); 49 ASSERT_FALSE(action->GetIsVisible(1));
48 action->SetIsVisible(ExtensionAction::kDefaultTabId, true); 50 action->SetIsVisible(ExtensionAction::kDefaultTabId, true);
49 ASSERT_TRUE(action->GetIsVisible(1)); 51 ASSERT_TRUE(action->GetIsVisible(1));
50 ASSERT_TRUE(action->GetIsVisible(100)); 52 ASSERT_TRUE(action->GetIsVisible(100));
51 53
52 action->SetIsVisible(ExtensionAction::kDefaultTabId, false); 54 action->SetIsVisible(ExtensionAction::kDefaultTabId, false);
53 ASSERT_FALSE(action->GetIsVisible(1)); 55 ASSERT_FALSE(action->GetIsVisible(1));
54 ASSERT_FALSE(action->GetIsVisible(100)); 56 ASSERT_FALSE(action->GetIsVisible(100));
55 action->SetIsVisible(100, true); 57 action->SetIsVisible(100, true);
56 ASSERT_FALSE(action->GetIsVisible(1)); 58 ASSERT_FALSE(action->GetIsVisible(1));
57 ASSERT_TRUE(action->GetIsVisible(100)); 59 ASSERT_TRUE(action->GetIsVisible(100));
58 60
59 action->ClearAllValuesForTab(100); 61 action->ClearAllValuesForTab(100);
60 ASSERT_FALSE(action->GetIsVisible(1)); 62 ASSERT_FALSE(action->GetIsVisible(1));
61 ASSERT_FALSE(action->GetIsVisible(100)); 63 ASSERT_FALSE(action->GetIsVisible(100));
62 64
63 scoped_ptr<ExtensionAction> browser_action = 65 std::unique_ptr<ExtensionAction> browser_action =
64 CreateAction(ActionInfo::TYPE_BROWSER, ActionInfo()); 66 CreateAction(ActionInfo::TYPE_BROWSER, ActionInfo());
65 ASSERT_TRUE(browser_action->GetIsVisible(1)); 67 ASSERT_TRUE(browser_action->GetIsVisible(1));
66 } 68 }
67 69
68 TEST(ExtensionActionTest, Icon) { 70 TEST(ExtensionActionTest, Icon) {
69 ActionInfo action_info; 71 ActionInfo action_info;
70 action_info.default_icon.Add(16, "icon16.png"); 72 action_info.default_icon.Add(16, "icon16.png");
71 scoped_ptr<ExtensionAction> page_action = 73 std::unique_ptr<ExtensionAction> page_action =
72 CreateAction(ActionInfo::TYPE_PAGE, action_info); 74 CreateAction(ActionInfo::TYPE_PAGE, action_info);
73 ASSERT_TRUE(page_action->default_icon()); 75 ASSERT_TRUE(page_action->default_icon());
74 EXPECT_EQ("icon16.png", 76 EXPECT_EQ("icon16.png",
75 page_action->default_icon()->Get( 77 page_action->default_icon()->Get(
76 16, ExtensionIconSet::MATCH_EXACTLY)); 78 16, ExtensionIconSet::MATCH_EXACTLY));
77 EXPECT_EQ("", 79 EXPECT_EQ("",
78 page_action->default_icon()->Get( 80 page_action->default_icon()->Get(
79 17, ExtensionIconSet::MATCH_BIGGER)); 81 17, ExtensionIconSet::MATCH_BIGGER));
80 } 82 }
81 83
82 TEST(ExtensionActionTest, Badge) { 84 TEST(ExtensionActionTest, Badge) {
83 scoped_ptr<ExtensionAction> action = 85 std::unique_ptr<ExtensionAction> action =
84 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo()); 86 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo());
85 ASSERT_EQ("", action->GetBadgeText(1)); 87 ASSERT_EQ("", action->GetBadgeText(1));
86 action->SetBadgeText(ExtensionAction::kDefaultTabId, "foo"); 88 action->SetBadgeText(ExtensionAction::kDefaultTabId, "foo");
87 ASSERT_EQ("foo", action->GetBadgeText(1)); 89 ASSERT_EQ("foo", action->GetBadgeText(1));
88 ASSERT_EQ("foo", action->GetBadgeText(100)); 90 ASSERT_EQ("foo", action->GetBadgeText(100));
89 action->SetBadgeText(100, "bar"); 91 action->SetBadgeText(100, "bar");
90 ASSERT_EQ("foo", action->GetBadgeText(1)); 92 ASSERT_EQ("foo", action->GetBadgeText(1));
91 ASSERT_EQ("bar", action->GetBadgeText(100)); 93 ASSERT_EQ("bar", action->GetBadgeText(100));
92 action->SetBadgeText(ExtensionAction::kDefaultTabId, "baz"); 94 action->SetBadgeText(ExtensionAction::kDefaultTabId, "baz");
93 ASSERT_EQ("baz", action->GetBadgeText(1)); 95 ASSERT_EQ("baz", action->GetBadgeText(1));
94 action->ClearAllValuesForTab(100); 96 action->ClearAllValuesForTab(100);
95 ASSERT_EQ("baz", action->GetBadgeText(100)); 97 ASSERT_EQ("baz", action->GetBadgeText(100));
96 } 98 }
97 99
98 TEST(ExtensionActionTest, BadgeTextColor) { 100 TEST(ExtensionActionTest, BadgeTextColor) {
99 scoped_ptr<ExtensionAction> action = 101 std::unique_ptr<ExtensionAction> action =
100 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo()); 102 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo());
101 ASSERT_EQ(0x00000000u, action->GetBadgeTextColor(1)); 103 ASSERT_EQ(0x00000000u, action->GetBadgeTextColor(1));
102 action->SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFFFF0000u); 104 action->SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFFFF0000u);
103 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(1)); 105 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(1));
104 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(100)); 106 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(100));
105 action->SetBadgeTextColor(100, 0xFF00FF00); 107 action->SetBadgeTextColor(100, 0xFF00FF00);
106 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(1)); 108 ASSERT_EQ(0xFFFF0000u, action->GetBadgeTextColor(1));
107 ASSERT_EQ(0xFF00FF00u, action->GetBadgeTextColor(100)); 109 ASSERT_EQ(0xFF00FF00u, action->GetBadgeTextColor(100));
108 action->SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFF0000FFu); 110 action->SetBadgeTextColor(ExtensionAction::kDefaultTabId, 0xFF0000FFu);
109 ASSERT_EQ(0xFF0000FFu, action->GetBadgeTextColor(1)); 111 ASSERT_EQ(0xFF0000FFu, action->GetBadgeTextColor(1));
110 action->ClearAllValuesForTab(100); 112 action->ClearAllValuesForTab(100);
111 ASSERT_EQ(0xFF0000FFu, action->GetBadgeTextColor(100)); 113 ASSERT_EQ(0xFF0000FFu, action->GetBadgeTextColor(100));
112 } 114 }
113 115
114 TEST(ExtensionActionTest, BadgeBackgroundColor) { 116 TEST(ExtensionActionTest, BadgeBackgroundColor) {
115 scoped_ptr<ExtensionAction> action = 117 std::unique_ptr<ExtensionAction> action =
116 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo()); 118 CreateAction(ActionInfo::TYPE_PAGE, ActionInfo());
117 ASSERT_EQ(0x00000000u, action->GetBadgeBackgroundColor(1)); 119 ASSERT_EQ(0x00000000u, action->GetBadgeBackgroundColor(1));
118 action->SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId, 120 action->SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId,
119 0xFFFF0000u); 121 0xFFFF0000u);
120 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(1)); 122 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(1));
121 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(100)); 123 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(100));
122 action->SetBadgeBackgroundColor(100, 0xFF00FF00); 124 action->SetBadgeBackgroundColor(100, 0xFF00FF00);
123 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(1)); 125 ASSERT_EQ(0xFFFF0000u, action->GetBadgeBackgroundColor(1));
124 ASSERT_EQ(0xFF00FF00u, action->GetBadgeBackgroundColor(100)); 126 ASSERT_EQ(0xFF00FF00u, action->GetBadgeBackgroundColor(100));
125 action->SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId, 127 action->SetBadgeBackgroundColor(ExtensionAction::kDefaultTabId,
126 0xFF0000FFu); 128 0xFF0000FFu);
127 ASSERT_EQ(0xFF0000FFu, action->GetBadgeBackgroundColor(1)); 129 ASSERT_EQ(0xFF0000FFu, action->GetBadgeBackgroundColor(1));
128 action->ClearAllValuesForTab(100); 130 action->ClearAllValuesForTab(100);
129 ASSERT_EQ(0xFF0000FFu, action->GetBadgeBackgroundColor(100)); 131 ASSERT_EQ(0xFF0000FFu, action->GetBadgeBackgroundColor(100));
130 } 132 }
131 133
132 TEST(ExtensionActionTest, PopupUrl) { 134 TEST(ExtensionActionTest, PopupUrl) {
133 GURL url_unset; 135 GURL url_unset;
134 GURL url_foo("http://www.example.com/foo.html"); 136 GURL url_foo("http://www.example.com/foo.html");
135 GURL url_bar("http://www.example.com/bar.html"); 137 GURL url_bar("http://www.example.com/bar.html");
136 GURL url_baz("http://www.example.com/baz.html"); 138 GURL url_baz("http://www.example.com/baz.html");
137 139
138 ActionInfo action_info; 140 ActionInfo action_info;
139 action_info.default_popup_url = url_foo; 141 action_info.default_popup_url = url_foo;
140 scoped_ptr<ExtensionAction> action = 142 std::unique_ptr<ExtensionAction> action =
141 CreateAction(ActionInfo::TYPE_PAGE, action_info); 143 CreateAction(ActionInfo::TYPE_PAGE, action_info);
142 144
143 ASSERT_EQ(url_foo, action->GetPopupUrl(1)); 145 ASSERT_EQ(url_foo, action->GetPopupUrl(1));
144 ASSERT_EQ(url_foo, action->GetPopupUrl(100)); 146 ASSERT_EQ(url_foo, action->GetPopupUrl(100));
145 ASSERT_TRUE(action->HasPopup(1)); 147 ASSERT_TRUE(action->HasPopup(1));
146 ASSERT_TRUE(action->HasPopup(100)); 148 ASSERT_TRUE(action->HasPopup(100));
147 149
148 action->SetPopupUrl(ExtensionAction::kDefaultTabId, url_unset); 150 action->SetPopupUrl(ExtensionAction::kDefaultTabId, url_unset);
149 ASSERT_EQ(url_unset, action->GetPopupUrl(1)); 151 ASSERT_EQ(url_unset, action->GetPopupUrl(1));
150 ASSERT_EQ(url_unset, action->GetPopupUrl(100)); 152 ASSERT_EQ(url_unset, action->GetPopupUrl(100));
151 ASSERT_FALSE(action->HasPopup(1)); 153 ASSERT_FALSE(action->HasPopup(1));
152 ASSERT_FALSE(action->HasPopup(100)); 154 ASSERT_FALSE(action->HasPopup(100));
153 155
154 action->SetPopupUrl(100, url_bar); 156 action->SetPopupUrl(100, url_bar);
155 ASSERT_EQ(url_unset, action->GetPopupUrl(1)); 157 ASSERT_EQ(url_unset, action->GetPopupUrl(1));
156 ASSERT_EQ(url_bar, action->GetPopupUrl(100)); 158 ASSERT_EQ(url_bar, action->GetPopupUrl(100));
157 159
158 action->SetPopupUrl(ExtensionAction::kDefaultTabId, url_baz); 160 action->SetPopupUrl(ExtensionAction::kDefaultTabId, url_baz);
159 ASSERT_EQ(url_baz, action->GetPopupUrl(1)); 161 ASSERT_EQ(url_baz, action->GetPopupUrl(1));
160 ASSERT_EQ(url_bar, action->GetPopupUrl(100)); 162 ASSERT_EQ(url_bar, action->GetPopupUrl(100));
161 163
162 action->ClearAllValuesForTab(100); 164 action->ClearAllValuesForTab(100);
163 ASSERT_EQ(url_baz, action->GetPopupUrl(1)); 165 ASSERT_EQ(url_baz, action->GetPopupUrl(1));
164 ASSERT_EQ(url_baz, action->GetPopupUrl(100)); 166 ASSERT_EQ(url_baz, action->GetPopupUrl(100));
165 } 167 }
166 168
167 } // namespace extensions 169 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_action_test_util.cc ('k') | chrome/browser/extensions/extension_api_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698