Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h" 5 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 if (!stdin_pipe.IsValid()) { 133 if (!stdin_pipe.IsValid()) {
134 LOG(ERROR) << "Failed to create pipe " << in_pipe_name; 134 LOG(ERROR) << "Failed to create pipe " << in_pipe_name;
135 return false; 135 return false;
136 } 136 }
137 137
138 DWORD comspec_length = ::GetEnvironmentVariable(L"COMSPEC", NULL, 0); 138 DWORD comspec_length = ::GetEnvironmentVariable(L"COMSPEC", NULL, 0);
139 if (comspec_length == 0) { 139 if (comspec_length == 0) {
140 LOG(ERROR) << "COMSPEC is not set"; 140 LOG(ERROR) << "COMSPEC is not set";
141 return false; 141 return false;
142 } 142 }
143 scoped_ptr<wchar_t[]> comspec(new wchar_t[comspec_length]); 143 std::unique_ptr<wchar_t[]> comspec(new wchar_t[comspec_length]);
144 ::GetEnvironmentVariable(L"COMSPEC", comspec.get(), comspec_length); 144 ::GetEnvironmentVariable(L"COMSPEC", comspec.get(), comspec_length);
145 145
146 base::string16 command_line_string = command_line.GetCommandLineString(); 146 base::string16 command_line_string = command_line.GetCommandLineString();
147 147
148 base::string16 command = base::StringPrintf( 148 base::string16 command = base::StringPrintf(
149 L"%ls /c %ls < %ls > %ls", comspec.get(), command_line_string.c_str(), 149 L"%ls /c %ls < %ls > %ls", comspec.get(), command_line_string.c_str(),
150 in_pipe_name.c_str(), out_pipe_name.c_str()); 150 in_pipe_name.c_str(), out_pipe_name.c_str());
151 151
152 base::LaunchOptions options; 152 base::LaunchOptions options;
153 options.start_hidden = true; 153 options.start_hidden = true;
(...skipping 17 matching lines...) Expand all
171 } 171 }
172 172
173 *process = std::move(cmd_process); 173 *process = std::move(cmd_process);
174 *read_file = base::File::CreateForAsyncHandle(stdout_pipe.Take()); 174 *read_file = base::File::CreateForAsyncHandle(stdout_pipe.Take());
175 *write_file = base::File::CreateForAsyncHandle(stdin_pipe.Take()); 175 *write_file = base::File::CreateForAsyncHandle(stdin_pipe.Take());
176 176
177 return true; 177 return true;
178 } 178 }
179 179
180 } // namespace extensions 180 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698