Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/extensions/api/image_writer_private/operation.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 image_writer_api::Stage stage_; 210 image_writer_api::Stage stage_;
211 int progress_; 211 int progress_;
212 212
213 // MD5 contexts don't play well with smart pointers. Just going to allocate 213 // MD5 contexts don't play well with smart pointers. Just going to allocate
214 // memory here. This requires that we only do one MD5 sum at a time. 214 // memory here. This requires that we only do one MD5 sum at a time.
215 base::MD5Context md5_context_; 215 base::MD5Context md5_context_;
216 216
217 // Zip reader for unzip operations. The reason for using a pointer is that we 217 // Zip reader for unzip operations. The reason for using a pointer is that we
218 // don't want to include zip_reader.h here which can mangle definitions in 218 // don't want to include zip_reader.h here which can mangle definitions in
219 // jni.h when included in the same file. See crbug.com/554199. 219 // jni.h when included in the same file. See crbug.com/554199.
220 scoped_ptr<zip::ZipReader> zip_reader_; 220 std::unique_ptr<zip::ZipReader> zip_reader_;
221 221
222 // CleanUp operations that must be run. All these functions are run on the 222 // CleanUp operations that must be run. All these functions are run on the
223 // FILE thread. 223 // FILE thread.
224 std::vector<base::Closure> cleanup_functions_; 224 std::vector<base::Closure> cleanup_functions_;
225 }; 225 };
226 226
227 } // namespace image_writer 227 } // namespace image_writer
228 } // namespace extensions 228 } // namespace extensions
229 229
230 #endif // CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_ 230 #endif // CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_OPERATION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698