Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/people_page/manage_profile.js

Issue 1871653002: Settings People Revamp: Update ManageProfileHandler to use Promises. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js » ('j') | chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/manage_profile.js
diff --git a/chrome/browser/resources/settings/people_page/manage_profile.js b/chrome/browser/resources/settings/people_page/manage_profile.js
index 243548da6eb903cdae19693e2ebb7bcd29fcd105..16b9e7a59a735f7e3fe2776a1c3f2aeadf41122b 100644
--- a/chrome/browser/resources/settings/people_page/manage_profile.js
+++ b/chrome/browser/resources/settings/people_page/manage_profile.js
@@ -49,7 +49,9 @@ Polymer({
this.availableIconUrls = iconUrls;
}.bind(this));
- this.browserProxy_.getAvailableIcons();
+ this.browserProxy_.getAvailableIcons().then(function(iconUrls) {
+ this.availableIconUrls = iconUrls;
+ }.bind(this));
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js » ('j') | chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698