Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: chrome/chrome.isolate

Issue 1871623002: Added chrome child pdb to isolate for static library builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.isolate
diff --git a/chrome/chrome.isolate b/chrome/chrome.isolate
index 7bfbc62dff7fb1092fe88119602bc40505581904..429aa479958e1086a0f185421922f1b64dd9df18 100644
--- a/chrome/chrome.isolate
+++ b/chrome/chrome.isolate
@@ -46,6 +46,13 @@
],
},
}],
+ ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
+ 'variables': {
+ 'files': [
+ '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX).pdb',
M-A Ruel 2016/04/07 18:07:58 you can use chrome.exe.pdb, it's more readable. I'
David Yen 2016/04/07 18:11:43 We are actually missing many PDBs, each of the DLL
+ ],
+ },
+ }],
['disable_nacl==0 and (OS=="win" or (OS=="linux" and target_arch=="x64"))', {
'variables': {
'files': [
@@ -114,17 +121,17 @@
],
},
}],
- ['OS=="win" and kasko==1', {
+ ['OS=="win" and component=="static_library" and (fastbuild==0 or fastbuild==1)', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/kasko.dll',
+ '<(PRODUCT_DIR)/chrome_child.dll.pdb',
],
},
}],
- ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
+ ['OS=="win" and kasko==1', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/chrome.exe.pdb',
+ '<(PRODUCT_DIR)/kasko.dll',
],
},
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698