Compute GpuDriverBugWorkarounds only one time in the GPU process

gpu/command_buffer/service/feature_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_FEATURE_INFO_H_
 #define GPU_COMMAND_BUFFER_SERVICE_FEATURE_INFO_H_
 
 #include <string>
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 #include "gpu/command_buffer/service/gles2_cmd_validation.h"
-#include "gpu/config/gpu_driver_bug_workaround_type.h"
+#include "gpu/config/gpu_driver_bug_workarounds.h"
 #include "gpu/gpu_export.h"
 
 namespace base {
 class CommandLine;
 }
 
 namespace gfx {
 struct GLVersionInfo;
 }
 
@@ skipping 58 matching lines @@
     bool chromium_image_ycbcr_420v;
     bool chromium_image_ycbcr_422;
     bool enable_subscribe_uniform;
     bool emulate_primitive_restart_fixed_index;
     bool ext_render_buffer_format_bgra8888;
     bool ext_multisample_compatibility;
     bool ext_blend_func_extended;
     bool ext_read_format_bgra;
   };
 
-  struct Workarounds {
-    Workarounds();
-
-#define GPU_OP(type, name) bool name;
-    GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
-#undef GPU_OP
-
-    // Note: 0 here means use driver limit.
-    GLint max_texture_size;
-    GLint max_cube_map_texture_size;
-    GLint max_fragment_uniform_vectors;
-    GLint max_varying_vectors;
-    GLint max_vertex_uniform_vectors;
-    GLint max_copy_texture_chromium_size;
-  };
-
   // Constructor with workarounds taken from the current process's CommandLine
-  FeatureInfo();
+  FeatureInfo(const GpuDriverBugWorkarounds& gpu_driver_bug_workarounds);

[piman, 2016/04/12 04:38:44]

nit: explicit

[Julien Isorce Samsung, 2016/04/12 16:11:32]

Done.

 
   // Constructor with workarounds taken from |command_line|
-  FeatureInfo(const base::CommandLine& command_line);
+  FeatureInfo(const base::CommandLine& command_line,
+              const GpuDriverBugWorkarounds& gpu_driver_bug_workarounds);
 
   // Initializes the feature information. Needs a current GL context.
   bool Initialize(ContextType context_type,
                   const DisallowedFeatures& disallowed_features);
 
   // Helper that defaults to no disallowed features and a GLES2 context.
   bool InitializeForTesting();
   // Helper that defaults to a GLES2 context.
   bool InitializeForTesting(const DisallowedFeatures& disallowed_features);
 
   const Validators* validators() const {
     return &validators_;
   }
 
   ContextType context_type() const { return context_type_; }
 
   const std::string& extensions() const {
     return extensions_;
   }
 
   const FeatureFlags& feature_flags() const {
     return feature_flags_;
   }
 
-  const Workarounds& workarounds() const {
-    return workarounds_;
-  }
+  const GpuDriverBugWorkarounds& workarounds() const { return workarounds_; }
 
   const DisallowedFeatures& disallowed_features() const {
     return disallowed_features_;
   }
 
   const gfx::GLVersionInfo& gl_version_info() const {
     DCHECK(gl_version_info_.get());
     return *(gl_version_info_.get());
   }
 
@@ skipping 30 matching lines @@
 
   ContextType context_type_;
 
   // The extensions string returned by glGetString(GL_EXTENSIONS);
   std::string extensions_;
 
   // Flags for some features
   FeatureFlags feature_flags_;
 
   // Flags for Workarounds.
-  Workarounds workarounds_;
+  const GpuDriverBugWorkarounds& workarounds_;
 
   // Whether the command line switch kEnableUnsafeES3APIs is passed in.
   bool enable_unsafe_es3_apis_switch_;
 
   bool unsafe_es3_apis_enabled_;
 
   bool chromium_color_buffer_float_rgba_available_;
   bool chromium_color_buffer_float_rgb_available_;
   bool ext_color_buffer_float_available_;
   bool oes_texture_float_linear_available_;
   bool oes_texture_half_float_linear_available_;
 
   bool disable_shader_translator_;
   scoped_ptr<gfx::GLVersionInfo> gl_version_info_;
 
   DISALLOW_COPY_AND_ASSIGN(FeatureInfo);
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_FEATURE_INFO_H_