Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1871573002: Breaking Change: Support @JS at library level (Closed)

Created:
4 years, 8 months ago by terry
Modified:
4 years, 8 months ago
Reviewers:
siva, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Sort patch file #

Patch Set 3 : Update tests for @JS() on library #

Patch Set 4 : Updated to WebKit updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3300 lines, -3283 lines) Patch
M sdk/lib/js/dartium/cached_patches.dart View 1 31 chunks +3280 lines, -3280 lines 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download
M tests/html/js_typed_interop_anonymous2_exp_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_anonymous2_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_anonymous_exp_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_anonymous_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_anonymous_unreachable_exp_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_anonymous_unreachable_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_side_cast_exp_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/js_typed_interop_side_cast_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/mirrors_js_typed_interop_test.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
terry
4 years, 8 months ago (2016-04-12 17:24:10 UTC) #1
Jacob
lgtm
4 years, 8 months ago (2016-04-12 17:26:38 UTC) #2
terry
4 years, 8 months ago (2016-04-12 17:29:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7146915ea83daa38ff138d317902147466c65bc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698