[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
Committed: https://crrev.com/ab3073f139ba46f0374b18657d7849bb8968a406
Cr-Commit-Position: refs/heads/master@{#386635}

[Mikhail, 2016-04-07 15:19:06]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
==========

[Mikhail, 2016-04-07 15:19:06]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, asargent@chromium.org

[Mikhail, 2016-04-07 15:20:14]

PTAL

[shalamov, 2016-04-08 11:14:56]

https://codereview.chromium.org/1871553003/diff/1/extensions/common/mojo/wifi...
File extensions/common/mojo/wifi_display_session_service.mojom (right):

https://codereview.chromium.org/1871553003/diff/1/extensions/common/mojo/wifi...
extensions/common/mojo/wifi_display_session_service.mojom:51:
SetDesinationPoint(string ip_address, int32 port);

What if address is invalid or port is already bound?
Maybe error callback would be useful here:
SetDesinationPoint(string ip_address, int32 port) => (Result);

enum Result {OK, IvalidAddress, AlreadyInUse} ?

[Mikhail, 2016-04-08 11:30:59]

On 2016/04/08 11:14:56, shalamov wrote:
>
https://codereview.chromium.org/1871553003/diff/1/extensions/common/mojo/wifi...
> File extensions/common/mojo/wifi_display_session_service.mojom (right):
> 
>
https://codereview.chromium.org/1871553003/diff/1/extensions/common/mojo/wifi...
> extensions/common/mojo/wifi_display_session_service.mojom:51:
> SetDesinationPoint(string ip_address, int32 port);
> 
> What if address is invalid or port is already bound?
> Maybe error callback would be useful here:
> SetDesinationPoint(string ip_address, int32 port) => (Result);
> 
> enum Result {OK, IvalidAddress, AlreadyInUse} ?

good point, but I think returning a 'bool' status flag might be enough.. I'll
update patch accordingly

[asargent_no_longer_on_chrome, 2016-04-11 17:57:54]

lgtm

[shalamov, 2016-04-12 09:21:03]

lgtm

[Mikhail, 2016-04-12 09:22:59]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-04-12 09:23:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1871553003/#ps20001
(title: "Added result callback to WiFiDisplayMediaService.SetDestinationPoint")

[commit-bot: I haz the power, 2016-04-12 09:23:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871553003/20001

[commit-bot: I haz the power, 2016-04-12 09:28:06]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
==========

[commit-bot: I haz the power, 2016-04-12 09:28:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-12 09:29:01]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Send media stream to sink (renderer part)

This patch adds functionality for sending packetized media stream to a sink
device (renderer process part).

BUG=242107

Committed: https://crrev.com/ab3073f139ba46f0374b18657d7849bb8968a406
Cr-Commit-Position: refs/heads/master@{#386635}
==========

[commit-bot: I haz the power, 2016-04-12 09:29:02]

Patchset 2 (id:??) landed as
https://crrev.com/ab3073f139ba46f0374b18657d7849bb8968a406
Cr-Commit-Position: refs/heads/master@{#386635}