Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1871503002: Lazily compute boundfunction .name and .length if possible (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Lazily compute boundfunction .name and .length if possible BUG= Committed: https://crrev.com/40290edf11dea892e49cc01288d2698cb42ab4a3 Cr-Commit-Position: refs/heads/master@{#35335}

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 2

Patch Set 3 : Addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -96 lines) Patch
M src/accessors.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 2 3 chunks +65 lines, -20 lines 0 comments Download
M src/api.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +52 lines, -30 lines 0 comments Download
M src/factory.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M src/objects.h View 4 chunks +6 lines, -13 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +38 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-07 11:09:42 UTC) #2
Camillo Bruni
lgtm with nits https://codereview.chromium.org/1871503002/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1871503002/diff/20001/src/objects.cc#newcode5108 src/objects.cc:5108: JSFunction::cast(function->bound_target_function())); nit: use isolate https://codereview.chromium.org/1871503002/diff/20001/src/objects.cc#newcode5111 src/objects.cc:5111: ...
4 years, 8 months ago (2016-04-07 13:04:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871503002/40001
4 years, 8 months ago (2016-04-07 13:11:09 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 13:36:48 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 13:38:09 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/40290edf11dea892e49cc01288d2698cb42ab4a3
Cr-Commit-Position: refs/heads/master@{#35335}

Powered by Google App Engine
This is Rietveld 408576698