[iOS/OSX] Refactor mac_framework so that it can be shared with iOS.

[iOS/OSX] Refactor mac_framework so that it can be shared with iOS.

Extract commonalities to framework_bundle and rename mac_framework to
mac_framework_bundle for consistency & introduce ios_framework_bundle.

Rename app template from build/config/ios/rules.gni to ios_app_bundle
for consistency.

BUG=None

Committed: https://crrev.com/1a969442c07ee8642074b4f204cdfb4c9e630995
Cr-Commit-Position: refs/heads/master@{#386673}

[sdefresne, 2016-04-11 09:34:18]

Patchset #1 (id:1) has been deleted

[sdefresne, 2016-04-11 09:35:19]

sdefresne@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, rsesek@chromium.org

[sdefresne, 2016-04-11 09:35:20]

rsesek: please take a look to the whole CL.

phajdan.jr: for OWNERS review of testing/test.gni

[Robert Sesek, 2016-04-11 15:35:27]

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (left):

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:53: "visibility",
Does the local visibility definition override here?

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:7: # Template to package a shared library into a
framework bundle.
"This is used as the base template for both iOS and Mac frameworks."

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:30: _framework_target = _target_name
Leave a comment here along the lines of:

"If the framework is un-versioned, the final _target_name will be the
create_bundle(_framework_target). If the framework is versioned, an action with
the final _target_name will depend on the create_bundle() target in order to
prepare the versioned directory structure."

[Paweł Hajdan Jr., 2016-04-11 15:53:33]

LGTM

[sdefresne, 2016-04-12 11:51:19]

Thank you for the review.

rsesek@: PTAL

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (left):

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:53: "visibility",
On 2016/04/11 at 15:35:26, Robert Sesek wrote:
> Does the local visibility definition override here?

I incorrectly removed "visibility" and "info_plist" here. Fixed, thank you for
spotting this.

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:7: # Template to package a shared library into a
framework bundle.
On 2016/04/11 at 15:35:26, Robert Sesek wrote:
> "This is used as the base template for both iOS and Mac frameworks."

Done.

https://codereview.chromium.org/1871413002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:30: _framework_target = _target_name
On 2016/04/11 at 15:35:26, Robert Sesek wrote:
> Leave a comment here along the lines of:
> 
> "If the framework is un-versioned, the final _target_name will be the
create_bundle(_framework_target). If the framework is versioned, an action with
the final _target_name will depend on the create_bundle() target in order to
prepare the versioned directory structure."

Done.

[Robert Sesek, 2016-04-12 13:44:15]

LGTM

[sdefresne, 2016-04-12 13:45:00]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-04-12 13:45:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1871413002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-04-12 13:45:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871413002/40001

[commit-bot: I haz the power, 2016-04-12 13:53:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-04-12 13:55:06]

Description was changed from

==========
[iOS/OSX] Refactor mac_framework so that it can be shared with iOS.

Extract commonalities to framework_bundle and rename mac_framework to
mac_framework_bundle for consistency & introduce ios_framework_bundle.

Rename app template from build/config/ios/rules.gni to ios_app_bundle
for consistency.

BUG=None
==========

to

==========
[iOS/OSX] Refactor mac_framework so that it can be shared with iOS.

Extract commonalities to framework_bundle and rename mac_framework to
mac_framework_bundle for consistency & introduce ios_framework_bundle.

Rename app template from build/config/ios/rules.gni to ios_app_bundle
for consistency.

BUG=None

Committed: https://crrev.com/1a969442c07ee8642074b4f204cdfb4c9e630995
Cr-Commit-Position: refs/heads/master@{#386673}
==========

[commit-bot: I haz the power, 2016-04-12 13:55:08]

Patchset 2 (id:??) landed as
https://crrev.com/1a969442c07ee8642074b4f204cdfb4c9e630995
Cr-Commit-Position: refs/heads/master@{#386673}