Issue 18714006: Collect garbage at the beginning of cctest/test-cpu-profiler/FunctionCallSample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18714006: Collect garbage at the beginning of cctest/test-cpu-profiler/FunctionCallSample (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Collect garbage at the beginning of cctest/test-cpu-profiler/FunctionCallSample That way, we don't end up collecting all samples in the garbage collector when the i18n extension is loaded. BUG=v8:2745 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15547

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	test/cctest/test-cpu-profiler.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jakob Kummerow

LGTM. Do we want/need the same GC call in other CpuProfiler tests too?

7 years, 5 months ago (2013-07-08 11:09:30 UTC) #2

jochen (gone - plz use gerrit)

On 2013/07/08 11:09:30, Jakob wrote: > LGTM. Do we want/need the same GC call in ...

7 years, 5 months ago (2013-07-08 11:12:05 UTC) #3

jochen (gone - plz use gerrit)

7 years, 5 months ago (2013-07-08 11:26:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15547 (presubmit successful).