Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 18714004: Make port unmapping errors non fatal. (Closed)

Created:
7 years, 5 months ago by Philippe
Modified:
7 years, 5 months ago
Reviewers:
bulach
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Make port unmapping errors non fatal. In some cases port unmapping can fail. This should not be fatal nor need client recovery code. This can happen when multiple instances of the Forwarder class try to map/unmap a same port. While the host_forwarder daemon supports that, the python wrapper didn't. R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/forwarder.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Philippe
FYI Marcus, this is needed to fix the ToT bot downstream.
7 years, 5 months ago (2013-07-05 14:19:19 UTC) #1
bulach
lgtm just checking: what are the conditions which this would fail? i.e., the port was ...
7 years, 5 months ago (2013-07-05 14:23:43 UTC) #2
Philippe
On 2013/07/05 14:23:43, bulach wrote: > lgtm > > just checking: what are the conditions ...
7 years, 5 months ago (2013-07-05 14:29:36 UTC) #3
Philippe
7 years, 5 months ago (2013-07-05 14:33:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r210306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698