chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated bmcquade's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc ('k') | chrome/chrome_browser.gypi » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 58f6beb76e931170656209889591a0ae904d827e..b063cdbc6f6afcb5b14d497dabd6c97839092e9f 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"

+#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h"

#include "chrome/browser/prerender/prerender_contents.h"

#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"

@@ -39,6 +40,8 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::WrapUnique(new chrome::StaleWhileRevalidateMetricsObserver()));

tracker->AddObserver(

base::WrapUnique(new DocumentWritePageLoadMetricsObserver()));

+ tracker->AddObserver(

+ base::WrapUnique(new ServiceWorkerPageLoadMetricsObserver()));

}

bool PageLoadMetricsEmbedder::IsPrerendering(