components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated bmcquade's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc ('K') | « chrome/chrome_browser.gypi ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index 311d857a2066b369c15323c41cb789cb835d96de..812c281152bc4132907a2328da8162658194096c 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -41,8 +41,10 @@ void MetricsRenderFrameObserver::DidChangePerformanceTiming() {

void MetricsRenderFrameObserver::DidObserveLoadingBehavior(

blink::WebLoadingBehaviorFlag behavior) {

- if (page_timing_metrics_sender_)

- page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);

+ if (!ShouldSendMetrics())

Charlie Harrison 2016/04/19 13:33:38 I don't think this is necessary. For in-page navig

horo 2016/04/19 15:04:15 Done.

+ return;

+ DCHECK(page_timing_metrics_sender_);

+ page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);

}

void MetricsRenderFrameObserver::DidCommitProvisionalLoad(