Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check page_timing_metrics_sender_ Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index ac22f9bc834e354e7d98f385695be53eead44a73..92c031d9cd386b17f850896c6efe6cc2ed6d6a22 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -429,6 +429,9 @@ void FrameLoader::receivedFirstData()
client()->dispatchDidCommitLoad(m_currentItem.get(), historyCommitType);
+ if (client()->isControlledByServiceWorker(*m_documentLoader))
Bryan McQuade 2016/04/14 15:10:26 i guess it's somewhat subtle, but this has to happ
horo 2016/04/14 15:46:31 Added comment.
+ client()->didObserveLoadingBehavior(WebLoadingBehaviorServiceWorkerControlled);
+
TRACE_EVENT1("devtools.timeline", "CommitLoad", "data", InspectorCommitLoadEvent::data(m_frame));
InspectorInstrumentation::didCommitLoad(m_frame, m_documentLoader.get());
m_frame->page()->didCommitLoad(m_frame);

Powered by Google App Engine
This is Rietveld 408576698