Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7368)

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check page_timing_metrics_sender_ Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..251dea60844e32c9b6b1dbd22b95a05cdc7cedb9
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
@@ -0,0 +1,46 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"
+#include "components/page_load_metrics/browser/page_load_metrics_util.h"
+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
+
+namespace internal {
+
+const char kHistogramServiceWorkerFirstContentfulPaint[] =
+ "PageLoad.Clients.ServiceWorker.Timing2.NavigationToFirstContentfulPaint";
+const char kBackgroundHistogramServiceWorkerFirstContentfulPaint[] =
+ "PageLoad.Clients.ServiceWorker.Timing2.NavigationToFirstContentfulPaint."
+ "Background";
+
+} // namespace internal
+
+ServiceWorkerPageLoadMetricsObserver::ServiceWorkerPageLoadMetricsObserver() {}
+
+void ServiceWorkerPageLoadMetricsObserver::OnComplete(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ if (timing.first_contentful_paint.is_zero())
+ return;
+ if (info.metadata.behavior_flags &
+ blink::WebLoadingBehaviorFlag::
+ WebLoadingBehaviorServiceWorkerControlled) {
+ LogDocumentWriteEvaluatorData(timing, info);
Bryan McQuade 2016/04/14 15:10:26 rename to LogServiceWorkerHistograms
horo 2016/04/14 15:46:31 Done.
+ }
+}
+
+void ServiceWorkerPageLoadMetricsObserver::LogDocumentWriteEvaluatorData(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ bool foreground_paint = WasStartedInForegroundEventInForeground(
+ timing.first_contentful_paint, info);
+ if (foreground_paint) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramServiceWorkerFirstContentfulPaint,
+ timing.first_contentful_paint);
+ } else {
+ PAGE_LOAD_HISTOGRAM(
+ internal::kBackgroundHistogramServiceWorkerFirstContentfulPaint,
+ timing.first_contentful_paint);
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698