third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/1857443002/#ps110001 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/renderer/metrics_render_frame_observer.cc ('K') | « components/page_load_metrics/renderer/metrics_render_frame_observer.cc ('k') | third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h » ('j') | third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index ac22f9bc834e354e7d98f385695be53eead44a73..92c031d9cd386b17f850896c6efe6cc2ed6d6a22 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -429,6 +429,9 @@ void FrameLoader::receivedFirstData()

client()->dispatchDidCommitLoad(m_currentItem.get(), historyCommitType);

+ if (client()->isControlledByServiceWorker(*m_documentLoader))

+ client()->didObserveLoadingBehavior(WebLoadingBehaviorServiceWorkerControlled);

TRACE_EVENT1("devtools.timeline", "CommitLoad", "data", InspectorCommitLoadEvent::data(m_frame));

InspectorInstrumentation::didCommitLoad(m_frame, m_documentLoader.get());

m_frame->page()->didCommitLoad(m_frame);