third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/1857443002/#ps110001 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/page_load_metrics/renderer/metrics_render_frame_observer.cc ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebLoadingBehaviorFlag_h	5 #ifndef WebLoadingBehaviorFlag_h

6 #define WebLoadingBehaviorFlag_h	6 #define WebLoadingBehaviorFlag_h

7	7

8 namespace blink {	8 namespace blink {

9	9

10 // This enum tracks certain behavior Blink exhibits when loading a page. This is	10 // This enum tracks certain behavior Blink exhibits when loading a page. This is

11 // for use in metrics collection by the loading team, to evaluate experimental	11 // for use in metrics collection by the loading team, to evaluate experimental

12 // features and potential areas of improvement in the loading stack. The main	12 // features and potential areas of improvement in the loading stack. The main

13 // consumer is the page_load_metrics component, which sends bit flags to the	13 // consumer is the page_load_metrics component, which sends bit flags to the

14 // browser process for histogram splitting.	14 // browser process for histogram splitting.

15 enum WebLoadingBehaviorFlag {	15 enum WebLoadingBehaviorFlag {

16 WebLoadingBehaviorNone = 0,	16 WebLoadingBehaviorNone = 0,

17 WebLoadingBehaviorDocumentWriteEvaluator = 1 << 0,	17 WebLoadingBehaviorDocumentWriteEvaluator = 1 << 0,

	18 WebLoadingBehaviorServiceWorkerControlled = 1 << 1,
	kinuko 2016/04/13 08:39:28 nit: in general we'd better have a short comment f nit: in general we'd better have a short comment for each in public/ (though we only have obvious ones so far) horo 2016/04/14 02:19:13 Done. Show quoted text On 2016/04/13 08:39:28, kinuko wrote: > nit: in general we'd better have a short comment for each in public/ (though we > only have obvious ones so far) Done.
18 };	19 };

19	20

20 } // namespace blink	21 } // namespace blink

21	22

22 #endif // WebLoadingBehaviorFlag_h	23 #endif // WebLoadingBehaviorFlag_h

OLD	NEW