tools/metrics/histograms/histograms.xml - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated ksakamoto's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index e3407522646576ba021a2bfe8cf0746037e45e7a..8fbff7b0c1042c6b497ce7c94d3cd3f96999cb66 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -90700,6 +90700,12 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PageLoad.Timing2.NavigationToLoadEventFired"/>

</histogram_suffixes>

+<histogram_suffixes name="PageLoadServiceWorker" separator=".">

+ <suffix name="ServiceWorker"

+ label="The page was controlled by the Service Worker."/>

+ <affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint"/>

+</histogram_suffixes>

<histogram_suffixes name="PageLoadType">

<suffix name="HistoryLoad"

label="but only for user pressing back or forward"/>

« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « third_party/WebKit/public/web/WebPerformance.h ('k') | no next file » | no next file with comments »