Fix parsing of max-age in SdchManager.

net/base/sdch_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 538 matching lines @@
   sdch_manager()->RemoveObserver(&observer);
   sdch_manager()->OnGetDictionary(test_request_gurl, test_dictionary_gurl);
   EXPECT_EQ(1, observer.get_dictionary_notifications());
   EXPECT_EQ(test_request_gurl, observer.last_dictionary_request_url());
   EXPECT_EQ(test_dictionary_gurl, observer.last_dictionary_url());
 }
 
 TEST_F(SdchManagerTest, ExpirationCheckedProperly) {
   // Create an SDCH dictionary with an expiration time in the past.
   std::string dictionary_domain("x.y.z.google.com");
+  // TODO(eroman): "max-age: -1" is invalid (it is not a valid production of
+  // delta-seconds, which is non-negative). This test works
+  // as a consequence of crbug.com/602691.

[Randy Smith (Not in Mondays), 2016/04/12 18:13:33]

Would you be willing to expand the second sentence?  I.e. "This test works
because currently an invalid max-age results in the dictionary being considered
expired on loading (crbug.com/602691)."

[eroman, 2016/04/12 18:26:21]

Done.

   std::string dictionary_text(base::StringPrintf("Domain: %s\nMax-age: -1\n\n",
                                                  dictionary_domain.c_str()));
   dictionary_text.append(
       kTestVcdiffDictionary, sizeof(kTestVcdiffDictionary) - 1);
   std::string client_hash;
   std::string server_hash;
   SdchManager::GenerateHash(dictionary_text, &client_hash, &server_hash);
   GURL target_gurl("http://" + dictionary_domain);
   AddSdchDictionary(dictionary_text, target_gurl);
 
@@ skipping 57 matching lines @@
   EXPECT_EQ(server_hash, observer.last_server_hash());
 
   EXPECT_EQ(SDCH_OK, sdch_manager()->RemoveSdchDictionary(server_hash));
   EXPECT_EQ(1, observer.dictionary_removed_notifications());
   EXPECT_EQ(server_hash, observer.last_server_hash());
 
   sdch_manager()->RemoveObserver(&observer);
 }
 
 }  // namespace net