Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1871343003: [compiler] Make --hydrogen-filter only apply to Crankshaft. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Make --hydrogen-filter only apply to Crankshaft. This makes sure that --hydrogen-filter only filters for Crankshaft, not for TurboFan compilations. For TurboFan there is --turbo-filter as a separate flag already. There no longer is a single flag to filter both compilers at the same time, one can still specify both flags however. R=jkummerow@chromium.org Committed: https://crrev.com/e37e6fc7666da45e418e5b842c2ce9735db67b91 Cr-Commit-Position: refs/heads/master@{#35388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-11 12:03:51 UTC) #3
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-11 13:03:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871343003/1
4 years, 8 months ago (2016-04-11 13:39:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 13:53:11 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 13:54:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e37e6fc7666da45e418e5b842c2ce9735db67b91
Cr-Commit-Position: refs/heads/master@{#35388}

Powered by Google App Engine
This is Rietveld 408576698