Remove PermissionContext factories

chrome/browser/push_messaging/push_messaging_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/push_messaging_service.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/permissions/permission_manager.h"
 #include "chrome/browser/permissions/permission_manager_factory.h"
 #include "chrome/browser/push_messaging/push_messaging_app_identifier.h"
 #include "chrome/browser/push_messaging/push_messaging_permission_context.h"
-#include "chrome/browser/push_messaging/push_messaging_permission_context_factory.h"
 #include "chrome/browser/push_messaging/push_messaging_service_factory.h"
 #include "chrome/browser/push_messaging/push_messaging_service_impl.h"
 #include "chrome/browser/services/gcm/fake_gcm_profile_service.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/test/base/testing_profile.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/gcm_driver/crypto/gcm_crypto_test_helpers.h"
 #include "components/gcm_driver/fake_gcm_client_factory.h"
 #include "components/gcm_driver/gcm_profile_service.h"
 #include "content/public/common/push_event_payload.h"
 #include "content/public/common/push_subscription_options.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
@@ skipping 14 matching lines @@
   }
 
   PermissionManager* GetPermissionManager() override {
     return PermissionManagerFactory::GetForProfile(this);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PushMessagingTestingProfile);
 };
 
-// Implementation of the PushMessagingPermissionContext that always allows usage
-// of Push Messaging, regardless of the actual implementation.
-class FakePushMessagingPermissionContext
-    : public PushMessagingPermissionContext {
- public:
-  explicit FakePushMessagingPermissionContext(Profile* profile)
-      : PushMessagingPermissionContext(profile) {}
-  ~FakePushMessagingPermissionContext() override {}
-
-  ContentSetting GetPermissionStatus(
-      const GURL& requesting_origin,
-      const GURL& embedding_origin) const override {
-    return CONTENT_SETTING_ALLOW;
-  }
-};
-
-scoped_ptr<KeyedService> BuildFakePushMessagingPermissionContext(
-    content::BrowserContext* context) {
-  return scoped_ptr<KeyedService>(
-      new FakePushMessagingPermissionContext(static_cast<Profile*>(context)));
-}
 
 scoped_ptr<KeyedService> BuildFakeGCMProfileService(
     content::BrowserContext* context) {
   return gcm::FakeGCMProfileService::Build(static_cast<Profile*>(context));
 }
 
 }  // namespace
 
 class PushMessagingServiceTest : public ::testing::Test {
  public:
   PushMessagingServiceTest() {
-    // Override the permission context factory to always allow Push Messaging.
-    PushMessagingPermissionContextFactory::GetInstance()->SetTestingFactory(
-        &profile_, &BuildFakePushMessagingPermissionContext);
+    // Always allow push notifications in the profile.
+    HostContentSettingsMap* host_content_settings_map =
+        HostContentSettingsMapFactory::GetForProfile(&profile_);
+    host_content_settings_map->SetDefaultContentSetting(
+        CONTENT_SETTINGS_TYPE_NOTIFICATIONS, CONTENT_SETTING_ALLOW);
+    host_content_settings_map->SetDefaultContentSetting(
+        CONTENT_SETTINGS_TYPE_PUSH_MESSAGING, CONTENT_SETTING_ALLOW);

[mlamouri (slow - plz ping), 2016/04/12 11:36:40]

Could we have a fake PermissionManager instead? No need to be addressed in this
CL.

 
     // Override the GCM Profile service so that we can send fake messages.
     gcm::GCMProfileServiceFactory::GetInstance()->SetTestingFactory(
         &profile_, &BuildFakeGCMProfileService);
   }
 
   ~PushMessagingServiceTest() override {}
 
   // Callback to use when the subscription may have been subscribed.
   void DidRegister(std::string* subscription_id_out,
@@ skipping 111 matching lines @@
   // (6) Verify that the message, as received by the Push Messaging Service, has
   // indeed been decrypted by the GCM Driver, and has been forwarded to the
   // Service Worker that has been associated with the subscription.
   EXPECT_EQ(app_identifier.app_id(), app_id);
   EXPECT_EQ(origin, dispatched_origin);
   EXPECT_EQ(service_worker_registration_id, kTestServiceWorkerId);
 
   EXPECT_FALSE(payload.is_null);
   EXPECT_EQ(kTestPayload, payload.data);
 }