Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18713004: Clear existing alarms when uninstalling extension. (Closed)

Created:
7 years, 5 months ago by zhchbin
Modified:
7 years, 5 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Clear existing alarms when uninstalling extension. BUG=258404 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhchbin
Please review.
7 years, 5 months ago (2013-07-09 14:05:17 UTC) #1
Finnur
LGTM
7 years, 5 months ago (2013-07-09 14:14:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/18713004/1
7 years, 5 months ago (2013-07-09 14:27:02 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 17:30:23 UTC) #4
Message was sent while issue was closed. 
Change committed as 210595

Powered by Google App Engine
This is Rietveld 408576698