Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1871243002: Change a flaky to Disabled. (Closed)

Created:
4 years, 8 months ago by Will Harris
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change a flaky to Disabled. FLAKY_ prefix seems to do absolutely nothing on the bots, and still turns the bot red, which makes it less easy to know when a real failure happens. BUG=600201 TBR=pkasting Committed: https://crrev.com/76d646a71434f1ecf0096c7db6fd44b0fe97a7d2 Cr-Commit-Position: refs/heads/master@{#386258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871243002/1
4 years, 8 months ago (2016-04-08 23:43:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-09 00:17:01 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76d646a71434f1ecf0096c7db6fd44b0fe97a7d2 Cr-Commit-Position: refs/heads/master@{#386258}
4 years, 8 months ago (2016-04-09 00:19:06 UTC) #10
Peter Kasting
4 years, 8 months ago (2016-04-11 20:08:14 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698