Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1871223003: Use ShellClientFactory interface to load mojo:profile (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wjmaclean, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ShellClientFactory interface to load mojo:profile - Adds a ShellConnection per BrowserContext so every running profile is a virtual browser application with a unique user ID. - Changes Shell to connect to SCF interfaces as itself while while inheriting the target SCF's user ID. - Adds a SCF to the BrowserContext shell connection - Exposes mojo:profile through BrowserContext's SCF - Exposes a mojo::Connector through BrowserContext and updates DOMStorageWrapper to use this instead of deprecated MojoAppConnection - Removes CurrentThreadLoader and DefaultLoader, which are no longer needed BUG=601884 TEST=localStorage still works for basic set/get in a tab with --mojo-local-storage on Committed: https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3 Cr-Commit-Position: refs/heads/master@{#387004}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -169 lines) Patch
M components/profile_service/BUILD.gn View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
A components/profile_service/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
M components/profile_service/profile_service.gyp View 1 2 3 4 2 chunks +27 lines, -1 line 0 comments Download
A + components/profile_service/public/cpp/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
A components/profile_service/public/cpp/constants.h View 1 chunk +14 lines, -0 lines 0 comments Download
A + components/profile_service/public/cpp/constants.cc View 1 2 3 4 1 chunk +4 lines, -7 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 7 chunks +85 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 3 4 7 chunks +14 lines, -11 lines 0 comments Download
A content/browser/mojo/browser_shell_connection.h View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download
A content/browser/mojo/browser_shell_connection.cc View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 4 8 chunks +27 lines, -49 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D content/common/mojo/current_thread_loader.h View 1 2 3 4 1 chunk +0 lines, -47 lines 0 comments Download
D content/common/mojo/current_thread_loader.cc View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
A content/common/mojo/embedded_application_runner.h View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A content/common/mojo/embedded_application_runner.cc View 1 2 3 4 1 chunk +90 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_resources.grd View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/browser_context.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/public/tools/manifest/manifest_collator.py View 1 chunk +8 lines, -0 lines 0 comments Download
M services/shell/shell.h View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M services/shell/shell.cc View 1 2 3 4 2 chunks +5 lines, -6 lines 0 comments Download
M services/shell/tests/connect/connect_test.mojom View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ken Rockot(use gerrit already)
erg@ for components/profile_service jam@ for content ben@ for mojo
4 years, 8 months ago (2016-04-11 16:46:26 UTC) #3
Elliot Glaysher
lgtm
4 years, 8 months ago (2016-04-11 17:51:53 UTC) #4
jam
lgtm
4 years, 8 months ago (2016-04-11 20:20:38 UTC) #5
Ken Rockot(use gerrit already)
ping ben
4 years, 8 months ago (2016-04-12 17:03:14 UTC) #6
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-12 17:10:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871223003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871223003/80001
4 years, 8 months ago (2016-04-13 15:32:20 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-13 16:33:36 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 16:36:57 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/963ad3e895f9bd9de01e428893c1423f524181d3
Cr-Commit-Position: refs/heads/master@{#387004}

Powered by Google App Engine
This is Rietveld 408576698